Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve internal opentelemetry logging #2128

Merged
merged 38 commits into from
Oct 4, 2024

Update opentelemetry-sdk/src/metrics/internal/mod.rs

3c4d20c
Select commit
Loading
Failed to load commit list.
Merged

Improve internal opentelemetry logging #2128

Update opentelemetry-sdk/src/metrics/internal/mod.rs
3c4d20c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 1s

79.0% (-0.1%) compared to 86dd486

View this Pull Request on Codecov

79.0% (-0.1%) compared to 86dd486

Details

Codecov Report

Attention: Patch coverage is 54.16667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (86dd486) to head (3c4d20c).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 19.0% 17 Missing ⚠️
opentelemetry-sdk/src/logs/log_emitter.rs 60.0% 2 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 0.0% 2 Missing ⚠️
opentelemetry-otlp/src/metric.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2128     +/-   ##
=======================================
- Coverage   79.0%   79.0%   -0.1%     
=======================================
  Files        121     121             
  Lines      20859   20856      -3     
=======================================
- Hits       16490   16482      -8     
- Misses      4369    4374      +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov