-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve urllib3 instrumentation examples #3347
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you go multiline with arguments, formatters format every line with a trailing comma
pass | ||
|
||
URLLib3Instrumentor().instrument( | ||
request_hook=request_hook, response_hook=response_hook | ||
request_hook=request_hook, | ||
response_hook=response_hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response_hook=response_hook | |
response_hook=response_hook, |
|
||
URLLib3Instrumentor().instrument( | ||
request_hook=request_hook, response_hook=response_hook | ||
request_hook=request_hook, | ||
response_hook=response_hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response_hook=response_hook | |
response_hook=response_hook, |
Description
There's one instrumentation example inside
urllib3
that doesn't run. This PR fixes the example, so it runs. It also ports instrumentation examples toREADME.rst
to match the examples in theurllib3
documentation.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
git clone https://github.com/open-telemetry/opentelemetry-python-contrib
git clone https://github.com/open-telemetry/opentelemetry-python
cd opentelemetry-python-contrib
python3 -m venv otelvenv
source otelvenv/bin/activate
urllib3
specific requirements:__init__.py
file into different Python files and try to run them.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.