[chore] Address TODO to migrate to VCRpy and remove bespoke RequestMocker code in Google GenAI SDK instrumentation #3344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revises the tests to split up into two different categories:
This addresses prior pull request feedback expressing concern regarding bespoke request mocking and deviation from typical pattern elsewhere of using the VCRpy component. This also addresses the original underlying concerns regarding velocity; since most tests do not use VCRpy and directly mock the underlying GenAI SDK, most feature changes can be tested with much simpler mocks of the GenAI SDK outputs.
Type of change
How Has This Been Tested?
Recorded with:
tox -e py312-test-instrumentation-google-genai-oldest --vcr-record=all
Ran the tests with:
tox -e py312-test-instrumentation-google-genai-oldest
Does This PR Require a Core Repo Change?