Add resource attributes to collector sidecar #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
|
@pavolloffay What do you think? |
frzifus
reviewed
Apr 21, 2022
Co-authored-by: Ben B. <bongartz@klimlive.de>
pavolloffay
reviewed
Apr 22, 2022
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
pavolloffay
reviewed
Apr 25, 2022
…mode Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
|
Updated the README |
pavolloffay
approved these changes
Apr 28, 2022
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
|
Done! |
pavolloffay
approved these changes
Apr 28, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add resource attributes to collector sidecar Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Update getAttributesEnv comments. Co-authored-by: Ben B. <bongartz@klimlive.de> * Use semconv package for attribute names Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Make env var names consistent Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Improve comments Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Rename attributes function Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * fix import order Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Verify env vars on sidecar e2e test Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * Update readme mentioning OTEL_RESOURCE_ATTRIBUTES env var on sidecar mode Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> * README Improvments Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com> Co-authored-by: Ben B. <bongartz@klimlive.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an env var
OTEL_RESOURCE_ATTRIBUTESto the sidecar pod, this envvar contains the k8s attributes of the pod, this is to be used for example with the resource detector processor to attach k8s attributes to spans,logs and metrics.Updates #573
Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com