Add autoinstrumentation for Python #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
force-pushed
the
autoinstrumentation-pyton
branch
from
e971264 to
c5bfb96
Compare
pavolloffay
reviewed
Nov 11, 2021
pkg/instrumentation/sdk.go
Outdated
| @@ -58,6 +58,12 @@ func inject(logger logr.Logger, insts languageInstrumentations, ns corev1.Namesp | |||
| pod = injectCommonSDKConfig(otelinst, ns, pod) | |||
| pod = injectNodeJSSDK(logger, otelinst.Spec.NodeJS, pod) | |||
| } | |||
| if insts.Python != nil { | |||
| otelinst := *insts.Python | |||
| logger.V(1).Info("injecting instrumentation into pod", "otelinst-namespace", otelinst.Namespace, "otelinst-name", otelinst.Name) | |||
There was a problem hiding this comment.
it would be good to include python in the log message
| container.Env[idx].Value = fmt.Sprintf("%s:%s:%s", pythonPathPrefix, container.Env[idx].Value, pythonPathSuffix) | ||
| } | ||
|
|
||
| // Set OTEL_TRACES_EXPORTER to HTTP exporter if not set by user because it is what our autoinstrumentation supports. |
There was a problem hiding this comment.
python does not support OTLP GRPC?
There was a problem hiding this comment.
It does but uses a native extension wrapping gRPC-C. This means the extension can only be loaded on the same python version as when pip install was invoked.
HTTP transport is pure python so avoids causing potential version problems.
There was a problem hiding this comment.
By the way related comment here
added 3 commits
November 17, 2021 13:16
…or into autoinstrumentation-pyton
pavolloffay
approved these changes
Nov 17, 2021
jpkrohling
approved these changes
Nov 17, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* Add autoinstrumentation for Python * Better log * Fix merge
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add autoinstrumentation for Python * Better log * Fix merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.