-
Notifications
You must be signed in to change notification settings - Fork 882
feat(sdk-metrics)!: drop View and Aggregation for options #4931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pichlermarc
merged 5 commits into
open-telemetry:next
from
dynatrace-oss-contrib:feat/remove-aggregation
Oct 8, 2024
Merged
feat(sdk-metrics)!: drop View and Aggregation for options #4931
pichlermarc
merged 5 commits into
open-telemetry:next
from
dynatrace-oss-contrib:feat/remove-aggregation
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d245ed6
to
5110fc9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4931 +/- ##
==========================================
- Coverage 93.96% 93.90% -0.06%
==========================================
Files 310 311 +1
Lines 8147 8172 +25
Branches 1630 1643 +13
==========================================
+ Hits 7655 7674 +19
- Misses 492 498 +6
|
david-luna
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Drops
Aggregation
andView
for options (AggregationOption
andViewOptions
, respectively). This means we will have two less classes exported from the@opentelemetry/sdk-metrics
package. This has a few benefits:Aggregation
is not user-implementable, so having only options makes this clearer.Aggregation
was supposed to be used in exporters, however its type does reference SDK internal types as well. This means that if these supposedly internal types change, the exporter may break too if it pins an older version of@opentelemetry/sdk-metrics
(which is a valid approach for writing an exporter).View
is really only used internally and not directly by the user, so writingnew View({...})
for each view is just additional work vs{...}
.Fixes #4654
Type of change
How Has This Been Tested?