Move ExponentialHistogram data to internal package. #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
jack-berg,
jkwatson and
jsuereth
as code owners
|
/cc @jamesmoessis |
Codecov Report
@@ Coverage Diff @@
## main #4217 +/- ##
============================================
- Coverage 90.28% 90.26% -0.02%
+ Complexity 4749 4748 -1
============================================
Files 553 553
Lines 14600 14602 +2
Branches 1402 1402
============================================
- Hits 13182 13181 -1
- Misses 958 963 +5
+ Partials 460 458 -2
Continue to review full report at Codecov.
|
anuraaga
force-pushed
the
eponentialhistogram-internal
branch
from
c7ea71a to
9eccb06
Compare
jamesmoessis
approved these changes
Feb 27, 2022
There was a problem hiding this comment.
LGTM, just not sure what the .attach_pid10327 file is. Is that supposed to be there?
anuraaga
force-pushed
the
eponentialhistogram-internal
branch
from
9eccb06 to
c762402
Compare
|
I approve..just need to put the "internal" scare text boilerplate on the public stuff moved in there. |
…nto eponentialhistogram-internal
jkwatson
reviewed
Mar 3, 2022
| DoubleExponentialHistogramData() {} | ||
| public static ExponentialHistogramData empty() { | ||
| return EMPTY; | ||
| } | ||
|
|
||
| /** | ||
| * Create a DoubleExponentialHistogramData. |
jkwatson
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We almost assuredly will mark metrics SDK stable without exponential histograms in the first version. So for now, we should move the code to an internal package.
I'm hoping not, but based on open-telemetry/opentelemetry-specification#2304 (comment) we may do similar for Exemplar if it's not finished for metrics SDK stable release. Optimistically leaving it in place for now.