Don't use hashmap for zpage buckets since the keys are constant. #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto and
jkwatson
as code owners
anuraaga
requested review from
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nullness checker found the usage of
Map.get()without null check, which in practice wasn't an issue since we prepopulate the map with all values of an enum. So in other words the keys to the maps were constant (well one of them only had one item inside). This made me think we should just use constants instead.We can expect a significant performance improvement since complete enumswitch is just a single jump (though switching from HashMap to EnumMap would have gotten very similar improvement, but still require adding nullness casts)