Add support for spring-pulsar 1.0 #13320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaydeluca Excuse me, could you kindly review this when you have some time? Thanks! |
laurit
reviewed
Feb 17, 2025
instrumentation/spring/spring-pulsar-1.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 17, 2025
instrumentation/spring/spring-pulsar-1.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 17, 2025
...est/java/io/opentelemetry/javaagent/instrumentation/spring/pulsar/v1_0/SpringPulsarTest.java
Outdated
Show resolved
Hide resolved
jaydeluca
reviewed
Feb 18, 2025
...est/java/io/opentelemetry/javaagent/instrumentation/spring/pulsar/v1_0/SpringPulsarTest.java
Outdated
Show resolved
Hide resolved
...est/java/io/opentelemetry/javaagent/instrumentation/spring/pulsar/v1_0/SpringPulsarTest.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Mar 10, 2025
steverao
reviewed
Mar 10, 2025
instrumentation/spring/spring-pulsar-1.2/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
| import org.apache.pulsar.client.api.Message; | ||
|
|
||
| public final class SpringPulsarSingletons { | ||
| private static final String INSTRUMENTATION_NAME = "io.opentelemetry.spring-pulsar-1.2"; |
There was a problem hiding this comment.
This is an unnecessary definition, it's just used once in this class.
There was a problem hiding this comment.
other instrumentations have similar INSTRUMENTATION_NAME filed, for example
steverao
reviewed
Mar 10, 2025
| AttributeKey.stringKey("messaging.pulsar.message.type"); | ||
|
|
||
| protected List<AttributeAssertion> publishAttributes() { | ||
| return Arrays.asList( |
There was a problem hiding this comment.
We'd use static import when it's used several time in a class. For detail, you can refer to https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/style-guideline.md#static-imports
steverao
reviewed
Mar 10, 2025
| implementation(project(":instrumentation:pulsar:pulsar-2.8:javaagent")) | ||
|
|
||
| testInstrumentation(project(":instrumentation:pulsar:pulsar-2.8:javaagent")) | ||
|
|
There was a problem hiding this comment.
other instrumetnations also leave a blank line between dependencies in different scopes, here testInstrumentation and testImplementation
steverao
reviewed
Mar 10, 2025
.../main/java/io/opentelemetry/instrumentation/spring/pulsar/v1_0/AbstractSpringPulsarTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13309