Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP grpc compression benchmarks #4640

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

jack-berg
Copy link
Member

Per request in PR #4632, splitting out the addition of compression benchmarks from the change in the default OTLP grpc compression algo.

Related to Issue #4587.

@jack-berg jack-berg requested review from a team and dmitryax January 5, 2022 19:56
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #4640 (809c176) into main (3db1d11) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4640      +/-   ##
==========================================
+ Coverage   90.25%   90.46%   +0.21%     
==========================================
  Files         181      181              
  Lines       10595    10611      +16     
==========================================
+ Hits         9562     9599      +37     
+ Misses        805      788      -17     
+ Partials      228      224       -4     
Impacted Files Coverage Δ
cmd/builder/internal/builder/config.go 84.50% <0.00%> (-1.02%) ⬇️
config/configauth/mock_serverauth.go
internal/configprovider/expand.go
internal/configprovider/merge.go
internal/configprovider/default.go
service/internal/configprovider/default.go 100.00% <0.00%> (ø)
config/configauth/default_serverauthenticator.go 100.00% <0.00%> (ø)
service/internal/configprovider/merge.go 91.17% <0.00%> (ø)
service/internal/configprovider/expand.go 78.18% <0.00%> (ø)
config/configgrpc/configgrpc.go 92.26% <0.00%> (+0.16%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db1d11...809c176. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 2dd0286 into open-telemetry:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants