-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exprfilterprocessor skeleton #1844
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
==========================================
- Coverage 91.29% 91.29% -0.01%
==========================================
Files 273 275 +2
Lines 16365 16387 +22
==========================================
+ Hits 14940 14960 +20
- Misses 998 999 +1
- Partials 427 428 +1
Continue to review full report at Codecov.
|
contribtest failure appears unrelated to this change |
It should also be able to filter on metric name so I would avoid calling it label anything. Also this is basically a datapoint filter in the end right or would it also be expanded to work with logs/traces? |
Yeah I have the same reservations about |
Renamed to |
@pmcollins yes, please provide the context of the change, what's the goal. Also, if this is a POC I suggest to move this to contrib repo. |
Yeah, we're going in a different direction than the proposal in the first readme so I deleted it. The design has been somewhat in flux but I'll capture what we have in a new readme. |
Have been working with Ben and Jay who know the context, but will add a readme and move to contrib. |
* use openjdk image in collectd-kafka test * Release v0.57.0
Description: Adds an exprfilterprocessor skeleton.
Testing: Unit tests added.