Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make registration of callback for async metric always optional #12204

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

bogdandrutu
Copy link
Member

This PR also solves one more issues with the new interface, which is the ability to record multiple observations for a single async metric using one callback.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners January 29, 2025 06:07
@bogdandrutu bogdandrutu force-pushed the all-optional-async branch 10 times, most recently from 2f98988 to 9233878 Compare January 29, 2025 16:30
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 67.01847% with 125 lines in your changes missing coverage. Please review.

Project coverage is 91.28%. Comparing base (d977da4) to head (53e231f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
service/internal/metadata/generated_telemetry.go 54.23% 42 Missing and 12 partials ⚠️
...terhelper/internal/metadata/generated_telemetry.go 56.25% 25 Missing and 3 partials ⚠️
...ereceiver/internal/metadata/generated_telemetry.go 74.41% 9 Missing and 2 partials ⚠️
...processor/internal/metadata/generated_telemetry.go 65.38% 7 Missing and 2 partials ⚠️
...ervice/internal/proctelemetry/process_telemetry.go 84.37% 4 Missing and 1 partial ⚠️
cmd/mdatagen/internal/samplereceiver/factory.go 82.35% 2 Missing and 1 partial ⚠️
processor/batchprocessor/metrics.go 62.50% 2 Missing and 1 partial ⚠️
...processor/internal/metadata/generated_telemetry.go 50.00% 2 Missing and 1 partial ⚠️
...sorhelper/internal/metadata/generated_telemetry.go 50.00% 2 Missing and 1 partial ⚠️
...verhelper/internal/metadata/generated_telemetry.go 50.00% 2 Missing and 1 partial ⚠️
... and 1 more

❌ Your patch status has failed because the patch coverage (67.01%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12204      +/-   ##
==========================================
- Coverage   91.84%   91.28%   -0.57%     
==========================================
  Files         465      465              
  Lines       25325    25608     +283     
==========================================
+ Hits        23261    23376     +115     
- Misses       1675     1819     +144     
- Partials      389      413      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 29, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Jan 29, 2025
Merged via the queue into open-telemetry:main with commit 3203167 Jan 30, 2025
53 of 54 checks passed
@bogdandrutu bogdandrutu deleted the all-optional-async branch January 30, 2025 00:17
sfc-gh-sili pushed a commit to sfc-gh-sili/opentelemetry-collector that referenced this pull request Feb 3, 2025
…telemetry#12204)

This PR also solves one more issues with the new interface, which is the
ability to record multiple observations for a single async metric using
one callback.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants