wip: update config dependency #11458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings in some breaking changes from the config package, mainly the headers on OTLP exporters are no longer a list of key value pairs but a list of name/value pairs. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/support-v0.3.0-config
branch
from
d5f583b to
744365d
Compare
1 task
This was referenced Oct 18, 2024
|
Related: #11478 |
|
Please can we get this PR completed and merged as its causing me a broken CI pipeline/build at the moment. |
|
@mjnowen working on it. this update requires a pretty substantial update in the collector's internal metrics configuration to preserve backwards compatibility. hoping to get to a good place for this update later this week |
|
Thanks @codeboten. FYI. I've been able to work around my issue temporarily with a |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
closing this in favour of #11611 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
This PR does a couple of things that I couldn't quite split up so I put together a PR w/ individual commits to help reviewers get through it. This PR does the following: 1. update `go.opentelemetry.io/contrib/config` package to latest. this brings in breaking changes. in order to prevent those breaking changes from impacting end users, i've also added a layer of config unmarshaling 2. updates the collector to instantiate the meter provider (and exporters) via the config package. this allows us to remove all the code in `otelinit`. the reason for including this change was that unmarshaling the config was causing circular dependencies i didn't want to address by moving code that could be deleted around. Replacement for #11458. Fixes #12021 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
sfc-gh-sili
pushed a commit
to sfc-gh-sili/opentelemetry-collector
that referenced
this pull request
Feb 3, 2025
This PR does a couple of things that I couldn't quite split up so I put together a PR w/ individual commits to help reviewers get through it. This PR does the following: 1. update `go.opentelemetry.io/contrib/config` package to latest. this brings in breaking changes. in order to prevent those breaking changes from impacting end users, i've also added a layer of config unmarshaling 2. updates the collector to instantiate the meter provider (and exporters) via the config package. this allows us to remove all the code in `otelinit`. the reason for including this change was that unmarshaling the config was causing circular dependencies i didn't want to address by moving code that could be deleted around. Replacement for open-telemetry#11458. Fixes open-telemetry#12021 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in some breaking changes from the config package, mainly the headers on OTLP exporters are no longer a list of key value pairs but a list of name/value pairs.