-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdatagen: metrics.go.tmpl broken filter import #12298
Labels
bug
Something isn't working
Comments
Also, that same PR that introduced generating scrapers doesn't correctly do so since it includes When running
|
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 28, 2025
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this issue
Feb 28, 2025
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Running the current mdatagen against receivers in collector-contrib directly breaks tests due to removal of the collector/filter import in
https://github.com/open-telemetry/opentelemetry-collector/pull/12092/files#diff-27825b678880d103cd17473d56b87f9fe90fe62f67eae7180bb85186e8742e32L19
Steps to reproduce
Here's an example for elasticsearch but seems to happen on other receivers as well.
What did you expect to see?
tests continue to pass
What did you see instead?
tests fail
What version did you use?
otel-collector-contrib@HEAD
mdatagen 0.119.0, reverting to 0.118.0 has the same issue, 0.117.0 worked as expected
What config did you use?
metadata file in elasticsearch receiver otel collector contrib
Environment
Ubuntu 20.04
Additional context
Contrib collector is still building, and those filter imports are still there, so wholly possible my setup is broken somehow - but at a basic level I don't see how removing the filter import from the template and relying on it later in the file is correct.
The text was updated successfully, but these errors were encountered: