[exporter/datadog] Replace HistogramMode defined as string with enum #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisku
force-pushed
the
keisku/use_enum_for_histogram_mode
branch
from
9881fc1 to
2781bce
Compare
keisku
force-pushed
the
keisku/use_enum_for_histogram_mode
branch
from
2781bce to
ffb9b2f
Compare
keisku
force-pushed
the
keisku/use_enum_for_histogram_mode
branch
from
7b00696 to
c049c65
Compare
mx-psi
approved these changes
May 2, 2022
mx-psi
approved these changes
May 2, 2022
mx-psi
added
the
ready to merge
|
For a maintainer to double check before merging: this has a breaking change on the Go API, since we switch from a string to string type alias. It will not break users of the binary. I believe the breakage is okay since it's hard to do in two steps and disruption is minimal, but I want a maintainer to explicitly approve this since it goes against the guidelines. |
codeboten
approved these changes
May 3, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…pen-telemetry#9589) * replace Histogram defined as string with enum * update CHANGELOG * move to Breaking changes * remove HistogramMode handling from Unmarshal()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replace HistogramConfig.Mode defined as string with translator.HistogramMode.
Link to tracking Issue: #8373
Testing:
Documentation: