fix baggage not work in trace demo app. #9418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jian.tan <jian.tan@daocloud.io>
|
|
jpkrohling
approved these changes
Apr 25, 2022
|
I think a changelog entry would indeed be useful for this. |
Sorry, I don't fully understand what's your meaning. Should I update something? |
Yes, the changelog file at the root of this repository, to inform users about this change. |
|
Ok, I didn't think it was a very important modification before, so I skipped it with |
Signed-off-by: jian.tan <jian.tan@daocloud.io>
cijothomas
reviewed
Apr 29, 2022
codeboten
reviewed
May 2, 2022
done. |
codeboten
added
the
ready to merge
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
* fix Baggage not work in demo app. Signed-off-by: jian.tan <jian.tan@daocloud.io> Co-authored-by: Alex Boten <aboten@lightstep.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jian.tan jian.tan@daocloud.io
Description: fix baggage not work in trace demo app.
refs: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/net/http/otelhttp/example/client/client.go#L52