Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce issuegenerator to open issues when tests fail on main #38177

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Introduce issuegenerator to open issues when tests fail on main #38177

merged 2 commits into from
Feb 25, 2025

Conversation

ArthurSens
Copy link
Member

Description

This PR extends the current unit test workflow to download the artifacts we started uploading at #37941. Further docs can be found here: https://github.com/actions/download-artifact

I'm also moving files around to make sure we start small. Generating issues only for the hostmetricsreceiver component. Once we notice that is working well I plan to raise another PR to cover all components of contrib

Link to tracking issue

Related to #36761

@ArthurSens
Introduce issuegenerator to open issues when tests fail on main
f815e11 
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
@ArthurSens ArthurSens requested a review from a team as a code owner February 25, 2025 13:23
@ArthurSens ArthurSens requested a review from dehaansa February 25, 2025 13:23
@ArthurSens
Copy link
Member Author

cc @mx-psi

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 25, 2025
mx-psi
mx-psi approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wanted to do the hostmetrics receiver because of these kinds of failures: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13521886685/job/37782822048 However these happen on ARM tests, which I think currently don't produce JUnit test results. I am fine merging this PR, but if I am right we would need to produce JUnit test results on those jobs as well

@ArthurSens
Copy link
Member Author

Hmmmm, I wonder what would happen if we included this automation on all arches. I think if the same test fails everywhere, we just spam the same issue. Not really a big deal 🤷

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Feb 25, 2025
@mx-psi
Copy link
Member

mx-psi commented Feb 25, 2025

Hmmmm, I wonder what would happen if we included this automation on all arches. I think if the same test fails everywhere, we just spam the same issue. Not really a big deal 🤷

I think it's not a big deal yep, it should be rare

@mx-psi mx-psi merged commit b072b17 into open-telemetry:main Feb 25, 2025
168 checks passed
@ArthurSens ArthurSens deleted the issuegenerator branch February 25, 2025 14:55
@github-actions github-actions bot added this to the next release milestone Feb 25, 2025
@ArthurSens ArthurSens mentioned this pull request Feb 25, 2025
Merged
@songy23
Copy link
Member

songy23 commented Feb 25, 2025

Is this really working? I saw the workflow fails consistently http://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13524013972/job/37791954191

@ArthurSens
Copy link
Member Author

Is this really working? I saw the workflow fails consistently http://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/13524013972/job/37791954191

Thanks for flagging it! Should we revert until we understand how to debug it?

@ArthurSens
Copy link
Member Author

Looking at workflow runs, I see that the JUnit tests are skipped.

image

Then I looked at the workflow again, silly mistake 🤦. We missed != true in the if condition

See

opentelemetry-collector-contrib/.github/workflows/build-and-test.yml

Line 289 in f119b52

if: startsWith( matrix.go-version, '1.23' ) != true

And

opentelemetry-collector-contrib/.github/workflows/build-and-test.yml

Line 292 in f119b52

if: startsWith( matrix.go-version, '1.23' ) # only run junit/coverage on one version

@ArthurSens ArthurSens mentioned this pull request Feb 26, 2025
Open
mx-psi pushed a commit that referenced this pull request Feb 26, 2025
@ArthurSens
Add issue generation from fkaly tests for all archs (#38191)
d5fdf81 
Addressing feedback from
#38177,
adds the same automation for the other archs

@mx-psi

---------

Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
ArthurSens added a commit to ArthurSens/opentelemetry-collector-contrib that referenced this pull request Feb 26, 2025
@ArthurSens
Revert "Introduce issuegenerator to open issues when tests fail on ma…
3961759 
…in (open-telemetry#38177)"

This reverts commit b072b17.
songy23 pushed a commit that referenced this pull request Feb 26, 2025
@ArthurSens
Revert "Introduce issuegenerator to open issues when tests fail on ma…
bdf034a 
…in (#38177)" (#38231)

This reverts commit b072b17.

When introducing the previous commit to main, we noticed the steps are
not well connected. For some reason that we're still investigating the
JUnit artifacts aren't uploaded and the last step that depends on them
always fail.
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 27, 2025
@yiquanzhou
Merge branch 'main' into add-cloud-provider-attribute
2778429 
* main: (22 commits)
  [receiver/awsfirehose] Add support for encoding extensions (open-telemetry#37262)
  fix(deps): update module google.golang.org/api to v0.223.0 (open-telemetry#38181)
  [chore] skip TestSyslogComplementaryRFC3164 (open-telemetry#38240)
  fix(deps): update module github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common to v1.0.1106 (open-telemetry#38199)
  [provider/s3] Use mdatagen, promote to alpha (open-telemetry#38227)
  fix: fix flaky test in kafkatopicsobserver (open-telemetry#38218)
  [processor/resourcedetection] Add k8s.cluster.uid to kubeadm detector (open-telemetry#38216)
  Revert "Add issue generation from fkaly tests for all archs (open-telemetry#38191)" (open-telemetry#38230)
  Revert "Introduce issuegenerator to open issues when tests fail on main (open-telemetry#38177)" (open-telemetry#38231)
  [chore] Update otelcol core dependency (open-telemetry#38214)
  [pkg/stanza] Improve error logs produced by transformer processors (open-telemetry#37285)
  [receiver/statsd] Make full config structure public (open-telemetry#38186)
  processor/metricsstarttime: add ridwanmsharif as codeowner (open-telemetry#38193)
  fix(deps): update module github.com/huaweicloud/huaweicloud-sdk-go-v3 to v0.1.137 (open-telemetry#38154)
  [pkg/datadog] export StaticAPIKeyCheck (open-telemetry#38223)
  [chore][pkg/ottl] Move scope and resource PathGetSetters to internal ctx packages (open-telemetry#38225)
  fix(deps): update all github.com/datadog packages to v0.64.0-rc.3 (open-telemetry#38202)
  feat(telemetrygen): added support for delta temporality (open-telemetry#38146)
  [chore] Some more fixes of component IDs (open-telemetry#38221)
  [chore][pkg/ottl] Define PathGetSetter in ctxdatapoint (open-telemetry#38201)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dehaansa dehaansa Awaiting requested review from dehaansa dehaansa is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@mwear mwear

Labels
ci-cd CI, CD, testing, build issues Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
4 participants
@ArthurSens @mx-psi @songy23 @mwear