Support excluding specific postgresql databases from stats collection #29605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Dec 1, 2023
djaglowski
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Thanks @recht. Just one more simple suggestion but this looks good to me.
There are cases where all except a few databases should be collected, for example the `rdsadmin` database in Amazon RDS is not accessible to regular users.
djaglowski
approved these changes
Dec 6, 2023
djaglowski
added
the
ready to merge
jayasai470
pushed a commit
to jayasai470/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2023
…open-telemetry#29605) **Description:** There are cases where all except a few databases should be collected, for example the `rdsadmin` database in Amazon RDS is not accessible to regular users. This PR adds an `exclude_databases` config setting to the psql collector where it's possible to specify a list of databases that should be excluded. **Testing:** Unit tests added **Documentation:** Readme updated with new config setting --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are cases where all except a few databases should be collected, for example the
rdsadmindatabase in Amazon RDS is not accessible to regular users. This PR adds anexclude_databasesconfig setting to the psql collector where it's possible to specify a list of databases that should be excluded.Testing:
Unit tests added
Documentation:
Readme updated with new config setting