-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruok command in zookeeper receiver #21481
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi @djaglowski, wanted to follow up |
Hi @akats7. Thanks for the proposal. Am I correct in understanding that this command is essentially a boolean health check? If so, my suggestion would be to model this as an Otherwise, can you clarify where you would add this as an attribute? |
Hey @djaglowski, thanks for the quick response. Yep it is a boolean health check, after looking at the example set you sent, I stumbled upon a mongodb health metric (here) that seems to be a analogous to what we're trying to see with zookeeper. It's of kind gauge with a numeric 1 or 0 to represent health. I think this would be a good fit. |
@akats7, that makes sense. Sounds good to me. |
Hey @djaglowski, the zookeeper server closes the socket after running each command, so to run the ruok command in the same scraper, we have to use multiple connections. I wanted to run it by you before I update the existing tests. I'll open and link a preliminary PR. |
**Description:** <Describe what has changed.> Add zookeeper ruok health check metric based on response from ruok 4lw command **NOTE**: preliminary PR not ready to be merged **Link to tracking Issue:** resolves #21481 **Testing:**: Modified existing unit tests to account for additional metric from additional command. Made minor change to test structure to account for separate text responses from separate commands. Added unit test to handle following cases, valid "imok" return from server, invalid response from server, and empty response from server.
**Description:** <Describe what has changed.> Add zookeeper ruok health check metric based on response from ruok 4lw command **NOTE**: preliminary PR not ready to be merged **Link to tracking Issue:** resolves open-telemetry#21481 **Testing:**: Modified existing unit tests to account for additional metric from additional command. Made minor change to test structure to account for separate text responses from separate commands. Added unit test to handle following cases, valid "imok" return from server, invalid response from server, and empty response from server.
**Description:** <Describe what has changed.> Add zookeeper ruok health check metric based on response from ruok 4lw command **NOTE**: preliminary PR not ready to be merged **Link to tracking Issue:** resolves open-telemetry#21481 **Testing:**: Modified existing unit tests to account for additional metric from additional command. Made minor change to test structure to account for separate text responses from separate commands. Added unit test to handle following cases, valid "imok" return from server, invalid response from server, and empty response from server.
Component(s)
receiver/zookeeper
Is your feature request related to a problem? Please describe.
Other zookeeper agents (e.g., datadog) support the ruok command along with the metric set from mntr, I wanted to inquire regarding adding a scraper to get the ruok response, and potentially adding it as an attribute as it likely doesn't belong in a metric table as a standalone.
Describe the solution you'd like
We would like the ruok response to be scraped along with the mntr metric set.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: