Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/awsecscontainermetricsreceiver] Add ServiceName metadata to be retrieved from task metadata endpoint #19728

Closed
erichsueh3 opened this issue Mar 15, 2023 · 2 comments
Closed

[receiver/awsecscontainermetricsreceiver] Add ServiceName metadata to be retrieved from task metadata endpoint #19728

erichsueh3 opened this issue Mar 15, 2023 · 2 comments
Labels
enhancement New feature or request receiver/awsecscontainermetrics

Comments

@erichsueh3
Copy link
Contributor

erichsueh3 commented Mar 15, 2023 •
edited by atoulme
Loading

Component(s)

receiver/awsecscontainermetrics

Is your feature request related to a problem? Please describe.

Currently, the awsecscontainermetricsreceiver returns "undefined" for ServiceName, see here. This is likely because this was implemented before ServiceName was available from the task metadata endpoint, however for Amazon ECS container agent versions 1.63.1 or later, it is available. 1.63.1 has been available for over 6 months now, and ServiceName should be added to the awsecscontainermetricsreceiver.

Describe the solution you'd like

Update the code for the awsecscontainermetricsreceiver to include ServiceName when receiving ECS container metrics.

Describe alternatives you've considered

No response

Additional context

No response
@erichsueh3 erichsueh3 added enhancement New feature or request needs triage New item requiring triage labels Mar 15, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@erichsueh3 erichsueh3 mentioned this issue Mar 15, 2023
Closed
@atoulme atoulme removed the needs triage New item requiring triage label Mar 15, 2023
@erichsueh3 erichsueh3 mentioned this issue Mar 16, 2023
Merged
codeboten pushed a commit that referenced this issue Mar 24, 2023
@erichsueh3
[receiver/awsecscontainermetricsreceiver] Add ServiceName metadata …
a45376d 
…to be retrieved from task metadata endpoint (PR) (#19744)

See tracking issue for description of problem being addressed.

Link to tracking Issue: #19728
@codeboten
Copy link
Contributor

Fixed by #19744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request receiver/awsecscontainermetrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @codeboten @erichsueh3