Add otelbot GitHub App to assets #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
otelbot
branch
2 times, most recently
from
c79ac6c to
bb4f8b1
Compare
trask
requested review from
alolita,
austinlparker,
danielgblanco,
jpkrohling,
mtwo,
mx-psi,
svrnm and
tedsuo
as code owners
svrnm
approved these changes
Feb 10, 2025
mx-psi
approved these changes
Feb 10, 2025
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
chalin
reviewed
Feb 12, 2025
|
Also, after the edits are made, could you run Prettier over this file (here or in a separate PR). |
chalin
reviewed
Feb 12, 2025
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
chalin
reviewed
Feb 12, 2025
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1549 and #2127.
This is more secure than using @opentelemetrybot (a repo can't grant more permissions that the app requests), and can be managed directly in the org (instead of as a separate github account with separate credentials).
May need other GitHub App "bots" with more permissions that are isolated to specific repos.
Opening as draft while I test things out in the Java instrumentation repo...