Issue 1066

[BillyDonahue]

Julian I took out the macros and tried to compress the unit tests a bit.
It's just a suggestion. You can take it or leave it, really.

[cdunn2001]

TIL about "Draft" pull-requests. Anyway, this is interesting. (re: #1066 and #1075)

[JulianvDoorn]

I have no idea how these drafts work, am I meant to merge this or is this simply an addition for #1075 ? Also- the travis-ci build fails which prevents merging, I can't seem to reproduce it on my own machine. And the error does not clearly indicate what's wrong.

[dota17]

I think this PR is better.

From the ci report, it fails in the case Linux xenial gcc cmake coverage.
The Travis-CI tells that there are some errors when building and testing with CMake.
I try to reproduce it on my own machine. When i build with CMake, i got these following errors:

/src/lib_json/../../include/json/value.h:419:13: error: explicit specialization in non-namespace scope 'class Json::Value'
   template <> bool as<bool>() const { return asBool(); }
             ^
....

And i got some same build errors when building with meson/ninja.

[BillyDonahue]

Oh, I forgot you can't specialize a template inside a class.
You just have to move the specializations outside the class.
I did that in 826228e