-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1066 #1080
Issue 1066 #1080
Conversation
Combine is<T> tests and combine as<T> tests.
I have no idea how these drafts work, am I meant to merge this or is this simply an addition for #1075 ? Also- the travis-ci build fails which prevents merging, I can't seem to reproduce it on my own machine. And the error does not clearly indicate what's wrong. |
I think this PR is better. From the ci report, it fails in the case
And i got some same build errors when building with meson/ninja. |
Oh, I forgot you can't specialize a template inside a class. |
Julian I took out the macros and tried to compress the unit tests a bit.
It's just a suggestion. You can take it or leave it, really.