Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose an option to support custom resolver resolution. #739

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

zcstarr
Copy link
Member

@zcstarr zcstarr commented Sep 24, 2021

This feature exposes two separate entry points for creating a resolver,
one using the makeCustomResolver() option and another for advanced
users that want more or need more control over the resolution process,
which allows users to extend the resolver class if needed.

fixes #587

@zcstarr zcstarr requested a review from shanejonas September 24, 2021 22:22
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #739 (3f765bc) into master (8eb2315) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #739   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          317       322    +5     
  Branches        72        74    +2     
=========================================
+ Hits           317       322    +5     
Impacted Files Coverage Δ
src/parse-open-rpc-document.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb2315...3f765bc. Read the comment docs.

This feature exposes two separate entry points for creating a resolver,
one using the makeCustomResolver() option and another for advanced
users that want more or need more control over the resolution process,
which allows users to extend the resolver class if needed.

fixes #587
@zcstarr zcstarr force-pushed the feat/custom-resolver-option branch from a622ed9 to 103f022 Compare September 24, 2021 22:38
Co-authored-by: Shane <jonas.shane@gmail.com>
@zcstarr zcstarr merged commit 6827197 into master Sep 24, 2021
@zcstarr zcstarr deleted the feat/custom-resolver-option branch September 24, 2021 23:06
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom protocol support
3 participants