Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Event Action Server #410

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Dynamic Event Action Server #410

wants to merge 3 commits into from

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Mar 18, 2025

This implements the dynamic event action server proposed in this discussion.

This PR depends on another PR for rmf_internal_msgs.

To use the new feature in this PR:

  • Create a composed task that contains a dynamic_event and dispatch it
  • Implement a dynamic event action client that issues goals for the dynamic action event server to follow

@TanJunKiat Maybe your team can help with testing by contributing a simple Python script to rmf_demos_tasks that does the following:

  • Subscribe to rmf/dynamic_event/begin to watch for a dynamic event to begin
  • When a new dynamic event begins, make an action client for rmf/dynamic_event/command/<fleet>/<robot>, wait for it to connect, and then issue a command based on CLI arguments given by --category and --file similar to dispatch_json.py
  • Wait for the event to finish and then quit

Let me know what you think and feel free to reach out for more guidance.

mxgrey added 2 commits March 17, 2025 23:25
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
@TanJunKiat
Copy link

TanJunKiat commented Mar 18, 2025

Thank you, @mxgrey, for taking the initiative to pilot this.

We will begin investigating this matter.

Would you prefer to create a dynamic_event branch in rmf_demos and for us to submit a pull request to that branch, or should we proceed directly to the main branch?

@mxgrey
Copy link
Contributor Author

mxgrey commented Mar 18, 2025

You can open a PR that directly targets main, and we'll merge all the related PRs at the same time.

If we find a reason later on for your changes to target a different branch, then I can edit your PR to retarget it when that's needed.

Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants