Implement encoder and decoder #34
Conversation
|
@bhess NP if you don't have time to review. I'll merge anyway only when the upstream PR is through; as that is pending OTC review that may take some time. fyi, time permitting on my side I'll proceed with hybrid (sig) support (based on this branch as I already added quite a few hooks for that). |
|
Sounds good to me @baentsch. At the moment I'm quite busy, but I was anyway interested to have a closer look at the OSSL3 encoders and the oqs-provider code. Hope to be able to do so in 1-2 weeks. |
Would be nice if you'd find time to do this soonish so I can avoid debugging into a breakage that now appeared only for all "x448" and "x25519" hybrids and apparently introduced by a recent upstream code change (hence not yet visible in the CCI run above). |
* Rename OSSL_PROVIDER_get0_name after openssl/openssl#15405 * Reverts workaround after bugfix in OpenSSL upstream (i2d_PrivateKey return value was incorrect) Adds oqs_kem_default Hybrid KEX is chosen according to bit_security defined in generate.yml, fixes inconsistenties between claimed_security_level and bit_security.
|
Feel free to already merge if it blocks. It won't be before end of the week when I will be able to take a closer look at the encoder. |
initial endecoder stubs added generate crypto objects added header corrections encode/decode tests passed for dil2 generate certs certgen working encrypted PK support added verbose test output just in case making OQS NIDs dynamic fully utilize nid as evp_type for OQS keys cert interop testing added full templatization
|
TWIMC: openssl/openssl#16770 was merged to OpenSSL master -> All interop tests now pass removing last merge block. |
Just decided it does. I need to move forward (completing open-quantum-safe/liboqs#1111) and progressing #3 for personal reasons (upcoming trip). Feedback still very welcome. |
Fixes #2
Next: Hybrid signature support (#3)
Possibly review: interop testing (#32)
TWIMC: The failing interop tests will be OK as and when openssl/openssl#16770 merges