Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull latest Kyber version from upstream #1631

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Pull latest Kyber version from upstream #1631

merged 1 commit into from
Dec 15, 2023

Conversation

bhess
Copy link
Member

@bhess bhess commented Dec 15, 2023

Pull latest Kyber version from upstream, which fixes a potential constant-time issue in the "ref" version as reported here:
https://groups.google.com/a/list.nist.gov/d/msgid/pqc-forum/ZXxUpck1501jEcRq%40localhost

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@baentsch
Copy link
Member

fixes a potential constant-time issue in the "ref" version

I assume it's intentional that a fix to "ref" code also changes "avx2" files?!

@bhess
Copy link
Member Author

bhess commented Dec 15, 2023

I assume it's intentional that a fix to "ref" code also changes "avx2" files?!

Good point. The update includes two separate commits upstream. The avx2 change is from the earlier commit: pq-crystals/kyber@9c32260.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants