-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor heads to support multiple heads #382
Conversation
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
- Coverage 82.44% 81.96% -0.49%
==========================================
Files 121 124 +3
Lines 8028 8235 +207
Branches 1298 1330 +32
==========================================
+ Hits 6619 6750 +131
- Misses 1145 1203 +58
- Partials 264 282 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Give a clear migration note on the first post. e.g., #288 |
mmpose/models/detectors/bottom_up.py
Outdated
""" | ||
|
||
def __init__(self, | ||
backbone, | ||
keypoint_head=None, | ||
train_cfg=None, | ||
test_cfg=None, | ||
pretrained=None, | ||
loss_pose=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better migration experience, we can keep loss_pose
here, and raise an error if it is not None, and give the link to this pr in the error message.
Two comments. |
* support multiple heads * name to loss_keypoint * update config * move loss_weight to losses * fix typo * fix comments * check * mv preds to heads * check * update init * multibatch for hands * support multibatch hand * rm unnecessary use_bbox_id * update bottomup inference * rm bbox_ids=None * if bbox_id not in img_metas then return None * keep loss_pose in detectors, and add some warnings. * keep loss_pose in detectors, and add some warnings. * keep loss_pose in detectors, and add some warnings.
* support multiple heads * name to loss_keypoint * update config * move loss_weight to losses * fix typo * fix comments * check * mv preds to heads * check * update init * multibatch for hands * support multibatch hand * rm unnecessary use_bbox_id * update bottomup inference * rm bbox_ids=None * if bbox_id not in img_metas then return None * keep loss_pose in detectors, and add some warnings. * keep loss_pose in detectors, and add some warnings. * keep loss_pose in detectors, and add some warnings.
fix #219
Migration note :
Config files need to be changed.
rename
loss_pose
toloss_keypoint
.move
loss_keypoint
from model settings to keypoint_head settings.For example, in
configs/top_down/hrnet/coco/hrnet_w32_coco_256x192.py
.from
to