Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix unittest in pt1.9 #1146

Merged
merged 7 commits into from
Jul 3, 2021
Merged

Conversation

zhouzaida
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix unittest in pt1.9

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne
Copy link
Collaborator

The version update of onnxruntime causes errors.

@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #1146 (1f3d16a) into master (6c63621) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files         159      159           
  Lines       10426    10426           
  Branches     1897     1897           
=======================================
  Hits         7089     7089           
  Misses       2968     2968           
  Partials      369      369           
Flag Coverage Δ
unittests 67.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c63621...1f3d16a. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 4a9f834 into open-mmlab:master Jul 3, 2021
@ZwwWayne ZwwWayne mentioned this pull request Jul 3, 2021
@zhouzaida zhouzaida deleted the fix-unittest branch July 3, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants