-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve check videos #950
Improve check videos #950
Conversation
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 83.72% 83.68% -0.05%
==========================================
Files 132 132
Lines 9983 9983
Branches 1722 1722
==========================================
- Hits 8358 8354 -4
- Misses 1210 1212 +2
- Partials 415 417 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a4e0860
to
4e84ab6
Compare
I made some changes and now LGTM |
14b13ed
to
68799d4
Compare
There are some problems with the
check_videos.py
script. I didn't see any current PR or issues on it so made this one.Also improved some minor stuff.
Bugs
The current way, len(f) doesn't work since objects don't have length. Corresponding error:
Added a function to get file length.
Minor improvements
pool = Pool(cpu_count() - 1 or 1)