Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Adjust script structure #935

Merged
merged 2 commits into from
Jun 23, 2021
Merged

[Improvement] Adjust script structure #935

merged 2 commits into from
Jun 23, 2021

Conversation

dreamerlin
Copy link
Collaborator

@dreamerlin dreamerlin commented Jun 17, 2021 •
edited
Loading

Add directories for scripts for tools, only leaving train and test related files

innerlee
innerlee reviewed Jun 17, 2021
View reviewed changes
configs/localization/bsn/README.md
@@ -71,7 +71,7 @@ You can use the following commands to inference a model.
2. For PGM Inference

```shell
python tools/bsn_proposal_generation.py ${CONFIG_FILE} [--mode ${MODE}]
python tools/misc/bsn_proposal_generation.py ${CONFIG_FILE} [--mode ${MODE}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misc is not a good name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any good idea?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as misc ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think misc is OK.

@codecov
Copy link

codecov bot commented Jun 17, 2021 •
edited
Loading

Codecov Report

Merging #935 (ce8af79) into master (aa26715) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
+ Coverage   83.68%   83.70%   +0.02%     
==========================================
  Files         132      132              
  Lines        9983     9983              
  Branches     1722     1722              
==========================================
+ Hits         8354     8356       +2     
  Misses       1211     1211              
+ Partials      418      416       -2
Flag Coverage Δ
unittests 83.70% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/augmentations.py 92.98% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa26715...ce8af79. Read the comment docs.

@dreamerlin dreamerlin requested a review from innerlee June 22, 2021 17:12
kennymckormick
kennymckormick reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@kennymckormick kennymckormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest not to place feature_extraction in misc, it's an important feature like training or testing. Besides, the dist_clip_feature_extraction.sh will not work now since the PYTHONPATH should also be altered.

@dreamerlin dreamerlin merged commit a6e8977 into open-mmlab:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennymckormick kennymckormick kennymckormick approved these changes

@innerlee innerlee Awaiting requested review from innerlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamerlin @innerlee @kennymckormick