Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Correct the key name of ‘eval_results’ dictionary for metric 'mmit_mean_average_precision' #885

Merged
merged 1 commit into from
May 25, 2021

Conversation

SCZwangxiao
Copy link
Contributor

Motivation

I was training my own multi-label classification dataset using metric mmit_mean_average_precision, and a KeyError occurred:

KeyError: 'mean_average_precision'.

I found that the evaluation results of metric mmit_mean_average_precisionwere stored in the dictionary eval_resultsusing a wrong key name mean_average_precision, which is responsible for this error.

Modification

Corrected the key name of dictionary eval_results in the file mmaction/datasets/base.py .
After this correction, the training process is running normally now.

@CLAassistant
Copy link

CLAassistant commented May 25, 2021

CLA assistant check
All committers have signed the CLA.

@SCZwangxiao SCZwangxiao changed the title Correct key name of ‘eval_results’ dictionary for metric 'mmit_mean_average_precision' [fix] Correct the key name of ‘eval_results’ dictionary for metric 'mmit_mean_average_precision' May 25, 2021
@innerlee innerlee requested review from dreamerlin and congee524 May 25, 2021 11:59
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #885 (975bdcd) into master (867b022) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head 975bdcd differs from pull request most recent head 90e50e0. Consider uploading reports for the commit 90e50e0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   83.28%   83.15%   -0.13%     
==========================================
  Files         129      129              
  Lines        9421     9423       +2     
  Branches     1612     1612              
==========================================
- Hits         7846     7836      -10     
- Misses       1184     1195      +11     
- Partials      391      392       +1     
Flag Coverage Δ
unittests 83.15% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/base.py 58.86% <0.00%> (-0.85%) ⬇️
mmaction/datasets/pipelines/augmentations.py 92.05% <0.00%> (-1.06%) ⬇️
mmaction/core/evaluation/accuracy.py 92.27% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867b022...90e50e0. Read the comment docs.

@kennymckormick kennymckormick merged commit ae5fb59 into open-mmlab:master May 25, 2021
@OpenMMLab-Coodinator
Copy link

Hi @SCZwangxiao !First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants