Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support TRN #755

Merged
merged 10 commits into from
Apr 8, 2021
Merged

[Feature] Support TRN #755

merged 10 commits into from
Apr 8, 2021

Conversation

congee524
Copy link
Contributor

No description provided.

@innerlee innerlee requested a review from dreamerlin March 25, 2021 05:51
@congee524 congee524 added the WIP work in progress label Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #755 (26acd3c) into master (6a252b8) will increase coverage by 0.08%.
The diff coverage is 93.54%.

❗ Current head 26acd3c differs from pull request most recent head 34e7f94. Consider uploading reports for the commit 34e7f94 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   85.19%   85.28%   +0.08%     
==========================================
  Files         130      131       +1     
  Lines        9418     9511      +93     
  Branches     1591     1602      +11     
==========================================
+ Hits         8024     8111      +87     
- Misses        997      999       +2     
- Partials      397      401       +4
Flag Coverage Δ
unittests 85.26% <93.54%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/__init__.py 100.00% <ø> (ø)
mmaction/models/heads/trn_head.py 93.47% <93.47%> (ø)
mmaction/models/heads/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a252b8...34e7f94. Read the comment docs.

kennymckormick
kennymckormick reviewed Mar 29, 2021
View reviewed changes
Copy link
Member

@kennymckormick kennymckormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you want to use a custom optimizer for TRN, but forget to add it?

@congee524 congee524 force-pushed the trn branch 2 times, most recently from 255fc3f to 589fdf5 Compare March 30, 2021 07:29
@congee524 congee524 added waiting for ckpts and removed WIP work in progress labels Mar 30, 2021
@congee524 congee524 changed the title [Features] Support TRN [Feature] Support TRN Apr 2, 2021
@congee524 congee524 requested a review from innerlee April 2, 2021 01:49
@dreamerlin

This comment has been minimized.

Sign in to view
@dreamerlin dreamerlin mentioned this pull request Apr 2, 2021
Closed
9 tasks
@congee524
Copy link
Contributor Author

@innerlee kindly ping :p

@innerlee

This comment has been minimized.

Sign in to view
@dreamerlin dreamerlin added the exist conflict This PR exists conflicts to be resolved label Apr 7, 2021
@congee524 congee524 removed the exist conflict This PR exists conflicts to be resolved label Apr 7, 2021
@innerlee innerlee merged commit 723e724 into open-mmlab:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennymckormick kennymckormick kennymckormick left review comments

@innerlee innerlee innerlee approved these changes

@dreamerlin dreamerlin dreamerlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@congee524 @dreamerlin @innerlee @kennymckormick