Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to output video or gif file in demo.py #72

Merged
merged 4 commits into from
Aug 1, 2020
Merged

Support to output video or gif file in demo.py #72

merged 4 commits into from
Aug 1, 2020

Conversation

dreamerlin
Copy link
Collaborator

  • Support output video or gif in demo.py.
  • Add output demo file (demo.gif and demo_out.mp4).

@dreamerlin dreamerlin requested a review from innerlee August 1, 2020 09:56
@dreamerlin dreamerlin changed the title Support output video or gif in demo.py Support to output video or gif file in demo.py Aug 1, 2020
@innerlee
Copy link
Contributor

innerlee commented Aug 1, 2020

demo.gif is too large. pls reduce the size below 1.5M

innerlee
innerlee reviewed Aug 1, 2020
View reviewed changes
innerlee
innerlee reviewed Aug 1, 2020
View reviewed changes
demo/demo.py Outdated
@@ -18,10 +20,84 @@ def parse_args():
help='whether to use rawframes as input')
parser.add_argument(
'--device', type=str, default='cuda:0', help='CPU/CUDA device option')
parser.add_argument(
'--fps', default=30, help='fps value of the output video')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fps should be None. if the input is video, then probe the input fps.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the description to "specify fps value of the output video when using rawframes to generate file"

@codecov
Copy link

codecov bot commented Aug 1, 2020 •
edited
Loading

Codecov Report

Merging #72 into master will increase coverage by 0.10%.
The diff coverage is 89.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   85.22%   85.32%   +0.10%     
==========================================
  Files          73       75       +2     
  Lines        3994     4083      +89     
  Branches      645      652       +7     
==========================================
+ Hits         3404     3484      +80     
- Misses        485      493       +8     
- Partials      105      106       +1
Flag Coverage Δ
#unittests 85.32% <89.88%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/__init__.py 100.00% <ø> (ø)
mmaction/models/losses/ohem_hinge_loss.py 75.75% <75.75%> (ø)
mmaction/models/losses/ssn_loss.py 98.14% <98.14%> (ø)
mmaction/models/losses/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a07fc2...949cbe7. Read the comment docs.

@innerlee
Copy link
Contributor

innerlee commented Aug 1, 2020

mmaction2_overview.gif is much larger than the current demo.gif

@dreamerlin
Copy link
Collaborator Author

mmaction2_overview.gif is much larger than the current demo.gif

They are both about 1.5MB.

@innerlee innerlee merged commit 98cef9e into open-mmlab:master Aug 1, 2020
@dreamerlin dreamerlin mentioned this pull request Aug 2, 2020
Closed
@dreamerlin dreamerlin deleted the gif branch August 10, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamerlin @innerlee