Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] CN tutorials #665

Merged
merged 25 commits into from
Mar 12, 2021
Merged

[Docs] CN tutorials #665

merged 25 commits into from
Mar 12, 2021

Conversation

dreamerlin
Copy link
Collaborator

@dreamerlin dreamerlin commented Mar 1, 2021

  1. I am dying
  2. Didn't think too much about the document structure

@dreamerlin
Copy link
Collaborator Author

@congee524 may help to find CN language support for readthedocs like this:
image

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #665 (424c27e) into master (ea0e722) will decrease coverage by 0.09%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   84.69%   84.59%   -0.10%     
==========================================
  Files         130      130              
  Lines        9338     9357      +19     
  Branches     1572     1578       +6     
==========================================
+ Hits         7909     7916       +7     
- Misses       1034     1042       +8     
- Partials      395      399       +4     
Flag Coverage Δ
unittests 84.58% <61.53%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/augmentations.py 94.83% <ø> (ø)
mmaction/models/backbones/resnet3d_slowfast.py 82.65% <33.33%> (-1.96%) ⬇️
mmaction/core/evaluation/eval_hooks.py 84.37% <55.55%> (-1.72%) ⬇️
mmaction/models/recognizers/base.py 64.54% <75.00%> (+0.46%) ⬆️
mmaction/models/recognizers/recognizer2d.py 98.03% <100.00%> (-0.04%) ⬇️
mmaction/models/heads/lfb_infer_head.py 45.00% <0.00%> (-2.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea0e722...9f2bd20. Read the comment docs.

@congee524
Copy link
Contributor

tooooo much... (o|o)
I'll see it later.

@dreamerlin dreamerlin requested review from innerlee and congee524 March 3, 2021 11:41
@dreamerlin dreamerlin mentioned this pull request Mar 3, 2021
10 tasks
@congee524
Copy link
Contributor

@congee524 @irvingzhang0512 How about checkpoint -> 模型检查点文件 ?

agree with it.

@dreamerlin dreamerlin requested review from innerlee and congee524 March 8, 2021 08:41
Comment on lines +47 to +48
对于在同一文件夹下的所有配置文件,MMAction2 推荐只存在 **一个** 对应的 _原始配置_ 文件。
所有其他的配置文件都应该继承 _原始配置_ 文件,这样就能保证配置文件的最大继承深度为 3。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you may need to confirm whether you need italics 原始配置 or underline word _原始配置_

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep the same with English one

@dreamerlin dreamerlin marked this pull request as ready for review March 10, 2021 15:12
@congee524
Copy link
Contributor

@innerlee Could it be merged now?

@congee524
Copy link
Contributor

@innerlee ping :p

@dreamerlin dreamerlin requested a review from innerlee March 12, 2021 07:27
@innerlee innerlee merged commit 13f42bf into open-mmlab:master Mar 12, 2021
@dreamerlin dreamerlin deleted the cn_tutorials branch March 25, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants