Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support TAM #595

Merged
merged 20 commits into from
Feb 19, 2021
Merged

[Feature] Support TAM #595

merged 20 commits into from
Feb 19, 2021

Conversation

congee524
Copy link
Contributor

Support TAM

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #595 (ec79c03) into master (e409809) will increase coverage by 0.16%.
The diff coverage is 95.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   84.26%   84.43%   +0.16%     
==========================================
  Files         124      126       +2     
  Lines        8771     8872     +101     
  Branches     1467     1481      +14     
==========================================
+ Hits         7391     7491     +100     
+ Misses       1022     1020       -2     
- Partials      358      361       +3     
Flag Coverage Δ
unittests 84.42% <95.09%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...action/core/optimizer/tsm_optimizer_constructor.py 84.61% <50.00%> (-1.66%) ⬇️
mmaction/models/heads/tsm_head.py 80.48% <50.00%> (-2.02%) ⬇️
mmaction/models/backbones/tanet.py 94.23% <94.23%> (ø)
mmaction/models/__init__.py 100.00% <100.00%> (ø)
mmaction/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmaction/models/common/__init__.py 100.00% <100.00%> (ø)
mmaction/models/common/tam.py 100.00% <100.00%> (ø)
mmaction/core/evaluation/eval_hooks.py 86.09% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e409809...ec79c03. Read the comment docs.

@congee524
Copy link
Contributor Author

This model is almost ready. Please review it when you are free.

@innerlee
Copy link
Contributor

innerlee commented Feb 8, 2021

Cool! @dreamerlin if you have time, please take a first pass on the code :)

type='SGD',
constructor='TSMOptimizerConstructor',
paramwise_cfg=dict(fc_lr5=True),
lr=0.02, # this lr is used for 8 gpus
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most cases, we use 64 (8 gpus x 8 batchs) samples for lr=0.01. please check it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TANet performs better with setting lr=0.02. I'm testing it on sthv1.

This comment was marked as outdated.

@dreamerlin

This comment has been minimized.

@congee524
Copy link
Contributor Author

kindly ping :)

type='SGD',
constructor='TSMOptimizerConstructor',
paramwise_cfg=dict(fc_lr5=True),
lr=0.02, # this lr is used for 8 gpus

This comment was marked as outdated.

@congee524
Copy link
Contributor Author

@innerlee Maybe @dreamerlin has done it. Could you take a moment to review the code?

@innerlee
Copy link
Contributor

Okay, soon

@innerlee innerlee merged commit 383c531 into open-mmlab:master Feb 19, 2021
@innerlee

This comment has been minimized.

@congee524 congee524 deleted the tam branch February 20, 2021 01:52
@congee524 congee524 mentioned this pull request Feb 25, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants