-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add solution for markdown-lint installation issue #497
Conversation
.github/CONTRIBUTING.md
Outdated
curl -L https://get.rvm.io | bash -s -- --autolibs=read-fail | ||
|
||
# set up environment | ||
echo 'source $HOME/.bash_profile' >> ~/.bashrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is not friendly
.github/CONTRIBUTING.md
Outdated
|
||
# set up environment | ||
echo 'source $HOME/.bash_profile' >> ~/.bashrc | ||
source ~/.profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
These commands are copied from mmdet. How about help to add script to install ruby>2.5 in |
ok i found it |
btw the setup repo lacks some steps of post-installation. There are several env variables need to be defined. Do you have intersest to have a try, and find out the missing steps? |
I am afraid I have no time these days. @congee524 , Could you help to do it? |
okk |
Do you mean the missing steps in the process of installing ruby, or all the install scrips? |
Sorry clicked the wrong button, didn't meant to approve this. My comments are still valid. |
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 84.69% 84.67% -0.03%
==========================================
Files 120 121 +1
Lines 8407 8526 +119
Branches 1373 1398 +25
==========================================
+ Hits 7120 7219 +99
- Misses 938 953 +15
- Partials 349 354 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No description provided.