-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in BaseHead default loss_factor. #446
Conversation
The problem is deeper. There must be some |
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 101 101
Lines 7201 7201
Branches 1161 1161
=======================================
Hits 6236 6236
Misses 733 733
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There is no **kwargs used in building heads and losses. The reason why we haven't tested it and no error being revealed is that, in BaseWeightedLoss, loss_weight is set to be 1.0 by default. And in all our usages(e.g. all configs), we override the |
Is |
Yes, but it will always be overridden together with the total dictionary of |
Fix docstring.
Fix typo.
No description provided.