Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the audio fusion result with a better tsn-f3 result. #281

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Update the audio fusion result with a better tsn-f3 result. #281

merged 3 commits into from
Oct 28, 2020

Conversation

SuX97
Copy link
Collaborator

@SuX97 SuX97 commented Oct 26, 2020

Fixes #280

@SuX97 SuX97 force-pushed the update_audio_fuse_result branch 2 times, most recently from d2aae48 to 41ac1f8 Compare October 26, 2020 09:32
@codecov
Copy link

codecov bot commented Oct 26, 2020 •
edited
Loading

Codecov Report

Merging #281 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #281   +/-   ##
=======================================
  Coverage   85.05%   85.05%           
=======================================
  Files          88       88           
  Lines        5994     5994           
  Branches      983      983           
=======================================
  Hits         5098     5098           
  Misses        709      709           
  Partials      187      187
Flag Coverage Δ
#unittests 85.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d7dca...c6b440d. Read the comment docs.

kennymckormick
kennymckormick reviewed Oct 27, 2020
View reviewed changes
Copy link
Member

@kennymckormick kennymckormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add a line in the changelog

@SuX97 SuX97 force-pushed the update_audio_fuse_result branch from 8e0c16e to 10d8da1 Compare October 27, 2020 04:26
@SuX97
Copy link
Collaborator Author

SuX97 commented Oct 27, 2020

Remember to add a line in the changelog

Updated.

@SuX97
Copy link
Collaborator Author

SuX97 commented Oct 28, 2020

ping @dreamerlin , ready to merge.

@innerlee
Copy link
Contributor

need to rebase

@SuX97 SuX97 force-pushed the update_audio_fuse_result branch from 10d8da1 to c6b440d Compare October 28, 2020 09:45
@SuX97
Copy link
Collaborator Author

SuX97 commented Oct 28, 2020

need to rebase

Rebased.

@innerlee innerlee merged commit d6f76cd into open-mmlab:master Oct 28, 2020
@dreamerlin dreamerlin mentioned this pull request Oct 30, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

@dreamerlin dreamerlin dreamerlin approved these changes

@kennymckormick kennymckormick kennymckormick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The performance of fusing RGB & Audio needs to be updated.
4 participants
@SuX97 @innerlee @dreamerlin @kennymckormick