Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] HVU Training #235

Merged
merged 38 commits into from
Oct 21, 2020
Merged

[Feature] HVU Training #235

merged 38 commits into from
Oct 21, 2020

Conversation

kennymckormick
Copy link
Member

Support HVU Training

HaodongDuan added 2 commits October 5, 2020 01:25
@codecov
Copy link

codecov bot commented Oct 10, 2020 •
edited
Loading

Codecov Report

Merging #235 into master will decrease coverage by 0.52%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   85.02%   84.50%   -0.53%     
==========================================
  Files          85       87       +2     
  Lines        5651     5880     +229     
  Branches      911      959      +48     
==========================================
+ Hits         4805     4969     +164     
- Misses        687      740      +53     
- Partials      159      171      +12
Flag Coverage Δ
#unittests 84.50% <75.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/evaluation/__init__.py 100.00% <ø> (ø)
mmaction/core/evaluation/eval_hooks.py 17.58% <ø> (ø)
mmaction/datasets/base.py 63.07% <0.00%> (-5.26%) ⬇️
mmaction/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmaction/models/__init__.py 100.00% <ø> (ø)
mmaction/models/recognizers/base.py 59.37% <31.25%> (-5.75%) ⬇️
mmaction/datasets/rawframe_dataset.py 82.45% <59.09%> (-3.41%) ⬇️
mmaction/models/heads/base.py 82.50% <60.00%> (-3.99%) ⬇️
mmaction/datasets/hvu_dataset.py 67.56% <67.56%> (ø)
mmaction/core/evaluation/accuracy.py 89.85% <85.71%> (-5.02%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd257a...6c6eda2. Read the comment docs.

@dreamerlin
Copy link
Collaborator

HVULoss and LoadHVULabel should be unittested.

@dreamerlin
Copy link
Collaborator

See https://codecov.io/gh/open-mmlab/mmaction2/pull/235/diff?src=pr&el=tree#diff-bW1hY3Rpb24vZGF0YXNldHMvYmFzZS5weQ== for detail

@kennymckormick
Copy link
Member Author

I think that PR is ready for merge, would you please do another check to see if there are still some problems? @dreamerlin @innerlee . I think the remaining work on HVU is just parameter tuning, the framework doesn't need to be changed.

@innerlee
Copy link
Contributor

ok, will look at it tomorrow

@dreamerlin dreamerlin added the exist conflict This PR exists conflicts to be resolved label Oct 21, 2020
@innerlee
Copy link
Contributor

linting error

@dreamerlin dreamerlin removed the exist conflict This PR exists conflicts to be resolved label Oct 21, 2020
@innerlee innerlee merged commit 3af8922 into open-mmlab:master Oct 21, 2020
@kennymckormick kennymckormick deleted the hvu_training branch October 29, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

@hellock hellock Awaiting requested review from hellock

@dreamerlin dreamerlin Awaiting requested review from dreamerlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennymckormick @dreamerlin @innerlee