-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release OmniSource ckpts #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 84.39% 84.32% -0.08%
==========================================
Files 78 78
Lines 4947 4937 -10
Branches 781 782 +1
==========================================
- Hits 4175 4163 -12
- Misses 643 644 +1
- Partials 129 130 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@innerlee seems OK |
projects/OmniSource/README.md
Outdated
@@ -0,0 +1,33 @@ | |||
# Omni-sourced Webly-supervised Learning for Video Recognition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the purpose of the projects folder? does it accept public pull requests?
will it be an exhibition?
what do you think? cc. @hellock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm thinking that, how about put the configs and readme under configs/weaklysupervised/omnisource
?
although the method might have used slowonly as the backbone, but it does not really belongs to the work of slowfast.
what do you think, @kennymckormick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, in this PR, we only release checkpoints of OmniSource. The training configs are not included (since we haven't released data & code). I think it's OK to put those checkpoints in the TSN and SlowOnly directory, since they are the architectures of these checkpoints. If we put them in another directory: 1. We do not have training configs now. 2. Few people will walk in that directory and see our work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, then how about put the readme in configs folder (and leave the inference configs where they are now)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, I plan to put the readme in the configs/OmniSource folder, add training configs to that folder after we support OmniSource training in MMAction2
No description provided.