Support loading url video in demo #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 85.92% 85.89% -0.03%
==========================================
Files 77 77
Lines 4845 4849 +4
Branches 765 765
==========================================
+ Hits 4163 4165 +2
- Misses 557 559 +2
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
add this to docs/docstring, and news/changelog |
innerlee
reviewed
Sep 8, 2020
docs/getting_started.md
Outdated
| @@ -262,6 +291,8 @@ the param `video` should be `VIDEO.mp4` (`VIDEO_NAME`). | |||
|
|
|||
| * When rawframes path is `VIDEO_NAME/img_xxxxx.jpg`, and `data_prefix` is None in the config file, the param `video` should be `VIDEO_NAME`. | |||
|
|
|||
| * In the video url case, it is the same with that of giving a video file path. | |||
There was a problem hiding this comment.
You can also pass a url instead of a video file path.
innerlee
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make
OpenCVInitsupport to load a video in a url format, which is corresponding with the changes in mmcv