Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX exporting support. #160

Merged
merged 8 commits into from
Sep 16, 2020
Merged

ONNX exporting support. #160

merged 8 commits into from
Sep 16, 2020

Conversation

SuX97
Copy link
Collaborator

@SuX97 SuX97 commented Sep 4, 2020

  • I3D

  • TSN

  • TIN

  • TSM

  • R2+1D

  • I3D

  • SLOWFAST

  • BMN

  • BSN

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #160 into master will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   85.87%   85.77%   -0.11%     
==========================================
  Files          77       77              
  Lines        4849     4849              
  Branches      765      765              
==========================================
- Hits         4164     4159       -5     
- Misses        559      561       +2     
- Partials      126      129       +3     
Flag Coverage Δ
#unittests 85.77% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/resnet3d_slowfast.py 87.97% <100.00%> (ø)
mmaction/core/evaluation/accuracy.py 92.30% <0.00%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501e52a...e83513f. Read the comment docs.

@SuX97
Copy link
Collaborator Author

SuX97 commented Sep 15, 2020

All models including localizers(BMN, tem, pem) tested, ready to be merged. @innerlee

@SuX97 SuX97 changed the title WIP: ONNX exporting support. ONNX exporting support. Sep 15, 2020
@innerlee
Copy link
Contributor

cool

@innerlee
Copy link
Contributor

Could you wrap the onnx import in a try catch, and put it here https://github.com/open-mmlab/mmaction2/blob/master/requirements/optional.txt?

@dreamerlin
Copy link
Collaborator

Remember to note this in change log. md

@innerlee
Copy link
Contributor

Adding a how-to in the tutorial section of documentation would be a big plus

Minor.

Minor.
@SuX97
Copy link
Collaborator Author

SuX97 commented Sep 16, 2020

Remember to note this in change log. md

change log and tutorial added.

@innerlee innerlee merged commit b77de1c into open-mmlab:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants