Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support topk customizing in models/heads/base.py #1452

Merged
merged 5 commits into from
Feb 20, 2022

Conversation

jamiechoi1995
Copy link
Contributor

Support topk customizing in models/heads/base.py

@kennymckormick
Copy link
Member

To merge this PR, please help to fix the lint problem.

@jamiechoi1995
Copy link
Contributor Author

yapf.....................................................................Failed
- hook id: yapf
- files were modified by this hook

I have no idea why yapf failed, can you please help me take a look of it? @kennymckormick

@dreamerlin
Copy link
Collaborator

dreamerlin commented Feb 19, 2022

yapf.....................................................................Failed
- hook id: yapf
- files were modified by this hook

I have no idea why yapf failed, can you please help me take a look of it? @kennymckormick

I try to modify your PR but failed, since Github "removed the Support for password authentication on August 13, 2021", and we can only use a personal access token now.

You can refer to https://github.com/open-mmlab/mmcv/blob/master/CONTRIBUTING.md to install pre-commit and run pre-commit run --all-files to fix it.

Or if you want, I can renew a PR for it

@kennymckormick
Copy link
Member

Just as @dreamerlin said, you need to run pre-commit run --all-files locally. You can try it next time, I have fixed the lint problem of this PR.

@kennymckormick kennymckormick merged commit 9bb896f into open-mmlab:master Feb 20, 2022
@jamiechoi1995
Copy link
Contributor Author

Thank you @kennymckormick @dreamerlin , I try to install pre-commit but failed due to the rbenv installation. I will run pre-commit before my next commit. Thank you for your help 👍

@jamiechoi1995 jamiechoi1995 deleted the jamiechoi1995-patch-1 branch February 20, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants