Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use official otel semantics in eval events #24

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: use official otel semantics in eval events #24

merged 1 commit into from
Feb 13, 2025

Conversation

beeme1mr
Copy link
Member

This PR

  • upgrades to the latest OFREP provider
  • update the telemetry hook to the telemetry function provided by the SDK

@beeme1mr
feat: use offical otel semantics in eval events
38f0561 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
lukas-reining
lukas-reining approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@beeme1mr beeme1mr added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 9525b72 Feb 13, 2025
2 checks passed
@openfeaturebot openfeaturebot mentioned this pull request Feb 3, 2025
Merged
@beeme1mr beeme1mr deleted the upgrade-ofrep branch February 13, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-reining lukas-reining lukas-reining approved these changes

@dyladan dyladan Awaiting requested review from dyladan

@kinyoklion kinyoklion Awaiting requested review from kinyoklion

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beeme1mr @lukas-reining