Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added interception of parameterized tests to Junit OpenFeature Extension #1093

Conversation

sebastian-zahrhuber
Copy link
Contributor

This PR

If the JUnit Open Feature Extension is used, a developer needs to use the @Flag annotation on test methods annotated with @Test and @ParameterizedTest. This PR adds support for parameterized tests.

Related Issues

Fixes #1091

@sebastian-zahrhuber sebastian-zahrhuber requested a review from a team as a code owner December 3, 2024 09:35
@github-actions github-actions bot requested a review from aepfli December 3, 2024 09:35
@sebastian-zahrhuber sebastian-zahrhuber force-pushed the feat-add-interception-of-parameterized-test-to-junitopen-feature-extension branch from 40c4c1e to 0c08cf3 Compare December 3, 2024 09:39
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks amazing. Just to make it more clear to the users, a small example in the readme would be highly appreciated.

…Extension

Signed-off-by: sebastian.zahrhuber <sebastian.zahrhuber@dynatrace.com>
Signed-off-by: sebastian.zahrhuber <sebastian.zahrhuber@dynatrace.com>
Signed-off-by: sebastian.zahrhuber <sebastian.zahrhuber@dynatrace.com>
@sebastian-zahrhuber sebastian-zahrhuber force-pushed the feat-add-interception-of-parameterized-test-to-junitopen-feature-extension branch from 7313259 to 26099bc Compare December 3, 2024 10:01
@aepfli aepfli merged commit a78c906 into open-feature:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Junit5 extension] Add Interception of @ParameterizedTest to JUnit Open Feature Extension
2 participants