-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: made EvaluationContext fields unexported with a constructor and setters to enforce immutability #91
Conversation
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 69.24% 69.68% +0.43%
==========================================
Files 7 8 +1
Lines 569 597 +28
==========================================
+ Hits 394 416 +22
- Misses 158 164 +6
Partials 17 17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…d setters to enforce immutability Signed-off-by: Skye Gill <gill.skye95@gmail.com>
1f3b60a
to
a1fbbbc
Compare
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
4eb9578
to
68166f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I think the only thing I'm missing here is the lock on global providers and hooks, as well as client hooks. We probably want to read-lock all of these during evaluation, and write lock them during mutation.
Great points. I've tackled this in another PR: #93 |
68166f3
to
68adbb1
Compare
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
68adbb1
to
610af7d
Compare
No description provided.