fix: internal provider comparison causing race conditions in tests #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warber
force-pushed
the
fix/provider-references
branch
2 times, most recently
from
c372d66 to
99644d2
Compare
erka
reviewed
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 86.91% 86.88% -0.04%
==========================================
Files 12 13 +1
Lines 1376 1372 -4
==========================================
- Hits 1196 1192 -4
Misses 156 156
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
warber
force-pushed
the
fix/provider-references
branch
2 times, most recently
from
e21dc2f to
3a36e19
Compare
|
@warber I think this solution solves the whole issue without putting constraints on the user, yes? IIUC, with this we:
Correct? |
Signed-off-by: Bernd Warmuth <bernd.warmuth@dynatrace.com>
warber
force-pushed
the
fix/provider-references
branch
from
3a36e19 to
1b18376
Compare
|
Hey @warber, is this still a work-in-progress or can it be reviewed now? |
beeme1mr
changed the title
aepfli
approved these changes
Jan 20, 2025
erka
approved these changes
Jan 20, 2025
thomaspoignant
approved these changes
Jan 20, 2025
toddbaert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This pull request addresses issue #307 by comparing FeatureProvider implementations internally using their pointer addresses. It inspects the FeatureProvider provided by the user and uses the == operator for comparison if dealing with pointers. Otherwise, it utilizes the existing deepEquals comparison.
Related Issues
Fixes #307
Notes
Follow-up Tasks
How to test