Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add structure in prepare_sector_network.py to specify implementation of storages as either Stores or StorageUnits #15

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Add structure in prepare_sector_network.py to specify implementation of storages as either Stores or StorageUnits #15

merged 9 commits into from
Oct 22, 2024

Conversation

daniel-rdt
Copy link

@daniel-rdt daniel-rdt commented Oct 15, 2024 •
edited
Loading

Addresses open-energy-transition#15.

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@daniel-rdt daniel-rdt changed the title Form feature/storageunits store Add structure in prepare_sector_network.py to specify implementation of storages as either Stores or StorageUnits Oct 15, 2024
@daniel-rdt daniel-rdt requested review from tgilon and martacki October 15, 2024 17:34
tgilon
tgilon reviewed Oct 18, 2024
View reviewed changes
Copy link

@tgilon tgilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a first review to test that everything is running. We will need the recent merge from upstream to get it working (see here).

tgilon
tgilon reviewed Oct 21, 2024
View reviewed changes
@daniel-rdt daniel-rdt merged commit 7b72243 into form_energy_storage Oct 22, 2024
@daniel-rdt daniel-rdt deleted the Form-feature/storageunits_store branch November 28, 2024 10:11
tgilon referenced this pull request in open-energy-transition/open-tyndp Feb 17, 2025
@tgilon @daniel-rdt
Retrieve data from TYNDP bundle (#15)
5e87916 
* add retrieve rule and script to retrieve TYNDP data bundle from Zenodo

* Improve doc string

* Add data retrieve as default for tyndp

* Shorten folder name

---------

Co-authored-by: daniel-rdt <daniel.ruedt@openenergytransition.org>
@daniel-rdt daniel-rdt mentioned this pull request Feb 24, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgilon tgilon tgilon left review comments

@martacki martacki Awaiting requested review from martacki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-rdt @tgilon