Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latex option and testing in the KPI plotting #59

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

virio-andreyana
Copy link

Changes proposed in this Pull Request

  • Add the option to enable/disable latex in the KPI plotting
  • disable latex if latex is not installed
  • test run the latex compilation and disable it if it does not work

Copy link
Collaborator

@daniel-rdt daniel-rdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing that is missing is that the latex test_and_enable also needs to be included in the plot_power_network script as I also enabled latex there because we included that plot in the results. But no way for you to have been awawre of this.

P.S.: And thanks for fixing the statistics warnings ;)

@virio-andreyana
Copy link
Author

Looks good. Only thing that is missing is that the latex test_and_enable also needs to be included in the plot_power_network script as I also enabled latex there because we included that plot in the results. But no way for you to have been aware of this.

P.S.: And thanks for fixing the statistics warnings ;)

I have to resort to putting this new code in the plot_power_network because plot_KPIs already imports load_projection from there. This is to prevent cyclic ImportError.

@daniel-rdt
Copy link
Collaborator

Ah, I see. Looks good now! LGTM

@virio-andreyana virio-andreyana merged commit 4bb2990 into form_energy_storage_dev Feb 4, 2025
@virio-andreyana virio-andreyana deleted the feature/latex-setting branch February 6, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants