-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ramping limit options for conventional powerplants in prepare_sector_network. #28
Add ramping limit options for conventional powerplants in prepare_sector_network. #28
Conversation
Looks good from my side. Thanks @virio-andreyana! Some notes:
|
I just found a subtle way to include this without adding any new code within the script. # docs in https://pypsa-eur.readthedocs.io/en/latest/configuration.html#adjustments
adjustment:
electricity:
absolute:
Generator:
nuclear:
ramp_limit_up: 0.5
ramp_limit_up: 0.5
p_min_pu: 0.5
sector:
absolute:
Link:
nuclear:
ramp_limit_up: 0.5
ramp_limit_up: 0.5
p_min_pu: 0.5 automatically add what we want without changing any of the scripts. What do you think @daniel-rdt ? If you agree, I'll clean everything up and just put this in config.default.yaml instead. |
Ready for review @tgilon @daniel-rdt. I've neglected my previous suggestion and continue with this one. |
I need some more time to review this thoroughly. Thus, I will not merge this into the dev branch yet and will start the updated run without the ramping and p_min_pu. We can decide after and include it then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of having all the nuclear tweaks at the same place in conventional
.
add @tgilon suggestion |
" France, a nuclear power plant is able to ramp up or down between 100% and 20% of nominal power in half an hour, and again after at least two hours, twice a day." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated p_min_pu
to 20% and removed ramping limits based on EDF source as quoted by @tgilon:
" France, a nuclear power plant is able to ramp up or down between 100% and 20% of nominal power in half an hour, and again after at least two hours, twice a day."
p_min_pu=cf_conventional.get(generator,{}).get("p_min_pu",0), | ||
ramp_limit_up=cf_conventional.get(generator,{}).get("ramp_limit_up",np.nan), | ||
ramp_limit_down=cf_conventional.get(generator,{}).get("ramp_limit_down",np.nan), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @daniel-rdt Spacing before )
has been changed
Closes #20
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.